Fix ANGLE on Windows, Linux, and MacOS #3718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm... it looks like I accidentally used a cached version of the binary in my Linux test project and didn't notice the ANGLE_USE_X11 compile definition being dropped. Testing Windows again and will push the fix (minor). |
|
Thanks for the PR! |
This was referenced Aug 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes ANGLE to build on Windows, Linux, and MacOS.
On Windows, the fix was to move the control flow guard flag (/guard:cf) to the compile options. The rest of it built fine.
On Linux and MacOS, the solution was primarily to exclude all D3D renderers and open up the OpenGL renderer to other platforms (it was marked as WINDOWS_DESKTOP only).
The platform specific portions are wgl, glx, and cgl for Windows, Linux, and MacOS respectively.