-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libjpeg-turbo] Update to libjpeg-turbo 2.0.1 #4635
Conversation
Similar to #4005 but there are diffs. |
052fdf1
to
2340edd
Compare
Update libjpeg-turbo port to libjpeg-turbo 2.0.0.
2340edd
to
80b1604
Compare
@alexkaratarakis Thank you for the information. I was read earlier sent pull request #4005. But, It contains some mistakes. It will install turbojpeg, but optimized libjpeg will not be installed. It is bug of patch. Should I feedback to earlier sent pull request? What do you think? |
@UnaNancyOwen It has been a while from the previous PR, so I think we should keep the discussions here. Currently running it through CI, will update with the results! :) |
There are regressions for
|
In the case of UWP (
|
@alexkaratarakis @ras0219-msft What do you think? |
Fix performing post-build validation on linux by remove man direcotry and files.
(It may be different from the actual machine because I tried on virtual machine,) In the case of Linux ( |
If you don't find other problem, I think ready to merge this pull request. |
In case of Debug configuration,
In addition, libjpeg-turbo 2.0.0 includes two additional functions. (
|
@alexkaratarakis I fixed these in #4703. Please review it. |
@alexkaratarakis I fixed these in this pull request and #4688. Please review it. |
@alexkaratarakis I fixed these in #4711. Please review it. (It does not seem to be related to this change.) |
It seems that all problems has been solved! 👍 |
Note: Only #4688 remaining, everything else is merged. |
Fix issue that fails rename when VCPKG_BUILD_TYPE is set.
Fix #4754 |
@UnaNancyOwen libjpeg-turbo 2.0.1 was released 2 weeks ago and contains some few very significant bug fixes. Furthermore in my limited testing I'd like to note that |
Update libjpeg-turbo port to libjpeg-turbo 2.0.1.
@lhecker Thanks! 👍 |
@alexkaratarakis @ras0219-msft I think ready to merge. |
Resolved merge conflicts and running CI tests. |
I am seeing the following regressions:
|
I think the only thing holding back this PR is the vcpkg CMAKE_SYSTEM_PROCESSOR bug. |
Update libjpeg-turbo port to libjpeg-turbo 2.0.0.
It contains bug fixes and performance improvements.