Updating HPX to V1.2 #4778
Updating HPX to V1.2 #4778
Conversation
| @@ -65,7 +61,7 @@ endif() | |||
|
|
|||
| file(GLOB DLLS ${CURRENT_PACKAGES_DIR}/lib/hpx/*.dll) | |||
| if(DLLS) | |||
| file(COPY ${DLLS} DESTINATION ${CURRENT_PACKAGES_DIR}/bin) | |||
| file(COPY ${DLLS} DESTINATION ${CURRENT_PACKAGES_DIR}/bin/hpx) | |||
There was a problem hiding this comment.
Why the change to put DLLs in a subdirectory? This will break our applocal deployment script.
There was a problem hiding this comment.
HPX relies on those DLL's to be in that subdirectory. They are loaded in special ways at runtime.
There was a problem hiding this comment.
Also, I think HPX doesn't like to be deployed to the application directory, I believe we have talked about some specific problems that has caused us. Is there a way disable deployment for HPX?
There was a problem hiding this comment.
Right; moving the binaries to this subdirectory will cause the binaries to not be deployed to the application directory, however any users will simply fail to run in this case (they'll hit F5 and their program will immediately crash).
When you say that HPX doesn't like to be deployed to the app directory and that you have special ways to load it at runtime, what do you mean specifically? Do you need to be deployed into a subdirectory of the app folder?
There was a problem hiding this comment.
@ras0219-msft In general it's the easiest to leave the HPX binaries where they have been installed. I will need to investigate this a bit further to ensure your app-deployment doesn't break things for us.
For now, let's go ahead with this PR as is (just leaving the binaries in the HPX subdir undeployed, HPX will work without them).
|
May I ask that this will be merged as is (for the time being)? |
|
Thanks and sorry for the long holiday delay! |
|
@ras0219-msft Thanks! |
No description provided.