Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenCV3] fix ffmpeg and ippicv prebuilt downloads #4789

Merged
merged 2 commits into from
Nov 22, 2018

Conversation

cenit
Copy link
Contributor

@cenit cenit commented Nov 21, 2018

fixes for prebuilt libs downloaded on the fly. The port is broken without these new refs

@ras0219-msft ras0219-msft self-assigned this Nov 22, 2018
@ras0219-msft ras0219-msft merged commit 5daa7ca into microsoft:master Nov 22, 2018
@ras0219-msft
Copy link
Contributor

Thanks for the PR!

@cenit
Copy link
Contributor Author

cenit commented Nov 22, 2018

why the ffmpeg_version.cmake filename change?

@ras0219-msft
Copy link
Contributor

I was concerned about reusing the file from the previous version, but I realize now that's how/why they're named based on hashes.

This was completely a regression added by me, sorry for the trouble!

@cenit cenit deleted the dev/cenit/opencv343 branch November 23, 2018 10:59
@cenit
Copy link
Contributor Author

cenit commented Nov 23, 2018

no problem
I will work soon on OpenCV again, maybe it's time to discuss again having different ports (opencv2, opencv3 and opencv - the last one moved to 4th rev - without loosing the previous version!!) and also using vcpkg's ffmpeg in opencv instead of the prebuilt one. OpenCV4 could be the perfect timing for this option, I think.
But we can discuss it in a proper place soon ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants