Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[czmq] Add new port #4979

Merged
merged 14 commits into from
Jul 2, 2019
Merged

[czmq] Add new port #4979

merged 14 commits into from
Jul 2, 2019

Conversation

myd7349
Copy link
Contributor

@myd7349 myd7349 commented Dec 15, 2018

Fix #5164 .

@myd7349
Copy link
Contributor Author

myd7349 commented Dec 15, 2018

Whoops! After updated to 2018-12-15, the linux x64 build is failed. It may be caused by libcurl package:

https://github.com/zeromq/czmq/blob/master/CMakeLists.txt#L186-L201

@myd7349 myd7349 changed the title [czmq] Add new port [WIP][czmq] Add new port Dec 16, 2018
@myd7349
Copy link
Contributor Author

myd7349 commented Dec 18, 2018

@myd7349 myd7349 changed the title [WIP][czmq] Add new port [czmq] Add new port Dec 21, 2018
@myd7349 myd7349 mentioned this pull request Jan 16, 2019
@myd7349 myd7349 changed the title [czmq] Add new port [WIP][czmq] Add new port Feb 23, 2019
@LarryIII LarryIII added the wip label Mar 6, 2019
@tg2k
Copy link

tg2k commented Mar 20, 2019

I'm new to vcpkg, but I was attempting to use this branch by making a local merge with master. I ran into an issue with libsodium where I ended up commenting out the debug DLL/lib installs from ports/libsodium/portfile.cmake , as they were missing. This could be because I have

set(VCPKG_BUILD_TYPE release)

in triplets/x64-windows.cmake .

In any case czmq fails for me like so:

-- Could NOT find LIBZMQ (missing: LIBZMQ_LIBRARIES) 
CMake Error at CMakeLists.txt:132 (message):
  libzmq not found.

I had run vcpkg install zeromq though and it reports it's installed:

zeromq:x64-windows 2019-01-30 The ZeroMQ lightweight messaging kernel is a lib...

The zeromq DLL I found was buildtrees\zeromq\x64-windows-rel\bin\libzmq-mt-4_3_2.dll . There was also a .lib under the lib folder. I'm not sure why CMake can't find libzmq.

@myd7349
Copy link
Contributor Author

myd7349 commented Mar 21, 2019

@tg2k Thanks for your interest in this PR. This PR still has room for improvement.

  1. ZeroMQ's sodium feature is not that perfect currently. The reason is explained here: [zeromq] Add sodium support and fix static build #4214 (comment) . I also created a PR for migrating libsodium's build system to CMake: [libsodium] Migrate build system to CMake #5600 , and it is almost done.

  2. I used several patch files under this PR, which is not that preferable. I was considering to fix some of the problems in the upstream repo, but I did not start this work yet.

I am on a bussiness trip these days. I will improve this PR when I am back.

@myd7349
Copy link
Contributor Author

myd7349 commented May 18, 2019

A big update today!
Test project: https://github.com/myd7349/Ongoing-Study/tree/master/c/ZeroMQ/czmq/ipc_test

Test on Windows with vcpkg install czmq[curl,draft,httpd,lz4,tool,uuid]

  • x86-windows
  • x86-windows-static
  • x64-windows
  • x64-windows-static

Test on Ubuntu with vcpkg install czmq[curl,draft,lz4,tool,uuid]

  • x64-linux

httpd feature failed on Linux because of: #6516

@myd7349
Copy link
Contributor Author

myd7349 commented Jun 2, 2019

It is very strange: Both vcpkg-Linux-PR and vcpkg-windows-PR are happy, but Vcpkg-PR-Eager is not happy.

@myd7349 myd7349 changed the title [WIP][czmq] Add new port [czmq] Add new port Jun 10, 2019
@myd7349
Copy link
Contributor Author

myd7349 commented Jun 10, 2019

Hi! @ras0219-msft I think I have finished this port now. Cheers!

@grdowns
Copy link
Contributor

grdowns commented Jul 1, 2019

Looks good, @myd7349! I caught a typo in use of the feature flag, it will be mergeable when finished. Thanks for adding vcpkg_check_features, by the way. It's very helpful!

@grdowns grdowns removed the wip label Jul 1, 2019
@myd7349
Copy link
Contributor Author

myd7349 commented Jul 2, 2019

Hi! @grdowns Thanks! Should I squash those commits to keep the commit message clean?

@grdowns
Copy link
Contributor

grdowns commented Jul 2, 2019

No need! We squash commits when we perform a merge (unless we make a mistake) 😆

@grdowns grdowns merged commit fb4cc37 into microsoft:master Jul 2, 2019
@myd7349 myd7349 deleted the czmq branch July 2, 2019 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help add repo czmq
4 participants