Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[boost] update boost to 1.69. Fixes #5023 #4961 #5059

Merged
merged 15 commits into from
Jan 31, 2019
Merged

[boost] update boost to 1.69. Fixes #5023 #4961 #5059

merged 15 commits into from
Jan 31, 2019

Conversation

McDamon
Copy link
Contributor

@McDamon McDamon commented Jan 1, 2019

- Remove boost-signal (rationale: deprecated and removed in 1.69)
- Remove boost-hana workaround by xiangfan-ms #4186 #3579 (rationale: 1.69 incorporates required fixes in hana master branch; builds fine in VS2017 15.9)
@msftclas
Copy link

msftclas commented Jan 1, 2019

CLA assistant check
All CLA requirements met.

@McDamon McDamon changed the title Update boost to 1.69. Fixes #5023 Update boost to 1.69. Fixes #5023 #4961 Jan 1, 2019
@McDamon McDamon changed the title Update boost to 1.69. Fixes #5023 #4961 [boost] update boost to 1.69. Fixes #5023 #4961 Jan 1, 2019
@ras0219-msft ras0219-msft self-assigned this Jan 8, 2019
@huangqinjin
Copy link
Contributor

New library SafeNumerics added in 1.69. Please add the port, thx @McDamon .

@@ -1,5 +1,5 @@
# Automatically generated by boost-vcpkg-helpers/generate-ports.ps1
Source: boost-ptr-container
Version: 1.68.0
Version: 1.69.0
Build-Depends: boost-array, boost-assert, boost-circular-buffer, boost-config, boost-core, boost-iterator, boost-mpl, boost-range, boost-serialization, boost-smart-ptr, boost-static-assert, boost-type-traits, boost-unordered, boost-utility, boost-vcpkg-helpers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears boost-ptr-container also depends on boost-thread, at least with arm-windows triplet in 1.68.

@janisozaur
Copy link
Contributor

Also boost-locale depends on boost-system and boost-thread

@ras0219-msft
Copy link
Contributor

Outstanding issues before we can merge this:

Processing arm-uwp                        313 vs 366
    boost-chrono                  **regression**                Fail vs Pass
    boost-regex                   **regression**                Fail vs Pass
    boost-signals                 **regression**                Fail vs Pass
Processing x64-osx                        524 vs 524
    libtorrent                    **regression**                Fail vs Pass
Processing x64-uwp                        402 vs 402
Processing x64-windows                    796 vs 800
    cartographer                  **regression**                Fail vs Pass
    hpx                           **regression**                Fail vs Pass
    libtorrent                    **regression**                Fail vs Pass
    wt                            **regression**                Fail vs Pass
Processing x64-windows-static             712 vs 714
    hpx                           **regression**                Fail vs Pass
    libtorrent                    **regression**                Fail vs Pass
Processing x86-windows                    779 vs 783
    cartographer                  **regression**                Fail vs Pass
    hpx                           **regression**                Fail vs Pass
    libtorrent                    **regression**                Fail vs Pass
    wt                            **regression**                Fail vs Pass

@janisozaur
Copy link
Contributor

janisozaur commented Jan 11, 2019

I filed boostorg/type_traits#105 which affects compilation of boost-regex and some more packages and it was fixed in boostorg/type_traits@5e7844b (a squashed version of boostorg/type_traits#106) so you may want to take that patch to fix arm builds. Subsequently, MSVC/ARM builds were added to type_traits' AppVeyor array.

@jasjuang
Copy link
Contributor

Looking forward to see the problem getting resolved and merged!

@janisozaur
Copy link
Contributor

@ras0219-msft I noticed your latest commit and that makes me wonder: I was recently trying to build a project using boost-iostreams and ran into lining errors regarding zlib and bzip2, like

error LNK2001: unresolved external symbol "protected: __thiscall boost::iostreams::detail::bzip2_base::~bzip2_base(void)" (??1bzip2_base@detail@iostreams@boost@@IAE@XZ)
error LNK2001: unresolved external symbol "protected: __thiscall boost::iostreams::detail::bzip2_base::bzip2_base(struct boost::iostreams::bzip2_params const &)" (??0bzip2_base@detail@iostreams@boost@@IAE@ABUbzip2_params@23@@Z)

(These errors are not mine, but look close enough)

I will try building when time allows to test with your latest change

@McDamon
Copy link
Contributor Author

McDamon commented Jan 20, 2019

New library SafeNumerics added in 1.69. Please add the port, thx @McDamon .

Added

@ras0219-msft ras0219-msft merged commit 0e75970 into microsoft:master Jan 31, 2019
@ras0219-msft
Copy link
Contributor

@janisozaur Thanks for filing that upstream -- I had developed an equivalent (but much longer) patch locally

Remove boost-signal (rationale: deprecated and removed in 1.69)

Unfortunately, it seems like we still have some ports depending on boost-signal, so for now we will leave it in at 1.68. It should no longer be installed by vcpkg install boost, however.

Thanks to everyone who pitched in on this, it's really exciting to see the next evolution of boost available through vcpkg!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

boost 1.69 is release please update
6 participants