Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port for arrayfire/forge rendering library #5242

Merged
merged 3 commits into from
Feb 2, 2019
Merged

Port for arrayfire/forge rendering library #5242

merged 3 commits into from
Feb 2, 2019

Conversation

9prady9
Copy link
Contributor

@9prady9 9prady9 commented Jan 27, 2019

I was able to successfully add and build the library.

However, I still have the following concerns.

  • forge has a non-windows only dependency which I am not sure how to specify in the CONTROL file. As of now, I declared it as dependency on every OS although it is only needed on non-windows platforms. - addressed.
  • Once, the installation of forge is complete - the help text that appears on the console shows Forge::forge twice in the target_link_libraries hint output instead of just once. I am not sure why it is happening. This is not a blocker but just ugly to look at when there is actually only one Forge::forge target. May be I am failing to see the mistake in forge's CMakeLists.txt. Any hints are appreciated. Thank you.

@msftclas
Copy link

msftclas commented Jan 27, 2019

CLA assistant check
All CLA requirements met.

@ras0219-msft ras0219-msft self-assigned this Jan 30, 2019
@ras0219-msft
Copy link
Contributor

Thanks for the PR!

forge has a non-windows only dependency which I am not sure how to specify in the CONTROL file. As of now, I declared it as dependency on every OS although it is only needed on non-windows platforms.

You can declare dependencies as conditional via annotations like zlib (windows) or openssl (!uwp&&!linux)

@9prady9
Copy link
Contributor Author

9prady9 commented Jan 30, 2019

@ras0219-msft An extra space is needed between package name and conditional statement within the parenthesis. That turned out to be the issue when I originally tried as follows.

Build-Depends: glfw3, fontconfig(!windows)

which gave the following error.

PS vcpkg> .\vcpkg.exe install forge:x64-windows --dry-run
Failed at [e:\gitroot\vcpkg\toolsrc\src\vcpkg\packagespec.cpp(37)] with message:
Contains invalid characters. Only alphanumeric lowercase ASCII characters and dashes are allowed

With the following however, it works as expected now.

Build-Depends: glfw3, fontconfig (!windows)

Thank you.

It would be nice if there is a note regarding this in the https://github.com/Microsoft/vcpkg/blob/master/docs/maintainers/control-files.md markdown page.

@9prady9
Copy link
Contributor Author

9prady9 commented Jan 30, 2019

@ras0219-msft I have modified the CONTROL file based on your feedback.

@ras0219-msft ras0219-msft merged commit 86f15d6 into microsoft:master Feb 2, 2019
@ras0219-msft
Copy link
Contributor

Thanks for the PR!

@9prady9 9prady9 deleted the forge branch February 2, 2019 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants