Port for arrayfire/forge rendering library #5242
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was able to successfully add and build the library.
However, I still have the following concerns.
forge has a non-windows only dependency which I am not sure how to specify in the CONTROL file. As of now, I declared it as dependency on every OS although it is only needed on non-windows platforms.- addressed.Forge::forge
twice in thetarget_link_libraries
hint output instead of just once. I am not sure why it is happening. This is not a blocker but just ugly to look at when there is actually only oneForge::forge
target. May be I am failing to see the mistake in forge's CMakeLists.txt. Any hints are appreciated. Thank you.