Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[coroutine]update source package hash. #5597

Merged
merged 3 commits into from
Mar 8, 2019
Merged

[coroutine]update source package hash. #5597

merged 3 commits into from
Mar 8, 2019

Conversation

JackBoosY
Copy link
Contributor

See #5593.

@JackBoosY JackBoosY added the info:internal This PR or Issue was filed by the vcpkg team. label Mar 8, 2019
@JackBoosY JackBoosY requested a review from grdowns March 8, 2019 08:49
@vicroms vicroms self-assigned this Mar 8, 2019
@@ -4,7 +4,7 @@ vcpkg_from_github(
OUT_SOURCE_PATH SOURCE_PATH
REPO luncliff/coroutine
REF 1.4
SHA512 981c9c728c7888995880a97e8533fa31f41085ef57e1c61e53e555f329d20d4a882d9de724d9e93e3d009dc3fe0669fe4d1af403654a9373e4aab44c933628a3
SHA512 6154988fca025a196d68ca025ce95fd972ed8aed15475d4da9d4038a4a3f498b1e0a4f570ff250f3a45e97b79ac6a2a2fe08abe645a389d5f1a68fd89cc58021
HEAD_REF master
)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on how often x86 came up in the error messages on the issue, this should probably be moved above the vcpkg_from_github

if(${VCPKG_TARGET_ARCHITECTURE} MATCHES x86)
    message(FATAL_ERROR "This library doesn't support x86 arch. Please use x64 instead or contact maintainer")
endif()

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rastaban Thanks for the fix. I will update that and make another PR in 2 days.

@vicroms vicroms merged commit 65f1d0e into microsoft:master Mar 8, 2019
@vicroms
Copy link
Member

vicroms commented Mar 8, 2019

Thanks @JackBoosY

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants