Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[angle] Fixed build with /permissive- MSVC toolchain and clang on Linux #5785

Merged
merged 1 commit into from
Mar 25, 2019
Merged

[angle] Fixed build with /permissive- MSVC toolchain and clang on Linux #5785

merged 1 commit into from
Mar 25, 2019

Conversation

qis
Copy link
Contributor

@qis qis commented Mar 23, 2019

The first change is to fix builds with MSVC toolchains that set /permissive- since ANGLE requires the old behavior.

The biggest offender is the macro NOTREACHED (src\common\third_party\base\anglebaselogging.h line 23).

I see no harm in forcing /permissive as it should not have any effect on builds with the default toolchain.

The second change is switching from hard-coded compile options to CMake properties, otherwise the port cannot be built with clang since the clang(1) executable does not support the -std=c++... command line options.

The CMAKE_CXX_STANDARD 17 property is supported since CMake version 3.8.2.
The CMAKE_POSITION_INDEPENDENT_CODE property improves try_compile support.

@Rastaban Rastaban merged commit 6798bc3 into microsoft:master Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants