Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[luajit]move luajit headers to the directory "include/luajit/" to avoid file conflicts. #5863

Merged
merged 6 commits into from
Mar 30, 2019
Merged

Conversation

JackBoosY
Copy link
Contributor

There are some file conflicts between them when building lua and luajit. So I modified the code to install the headers.

See #4019.

And I suggest that new port requests should also do this.

@JackBoosY JackBoosY added the info:internal This PR or Issue was filed by the vcpkg team. label Mar 29, 2019
@Rastaban Rastaban merged commit db13360 into microsoft:master Mar 30, 2019
@pfirsich
Copy link

This breaks sol2 with luajit, because it assumes it can include <lua.h> and not <luajit/lua.h>. As LuaJIT is a drop-in replacement of Lua, it should simply not be allowed to install them both. The old behavior that resulted in an error is imho the right thing to do.

@dg0yt
Copy link
Contributor

dg0yt commented May 29, 2023

This breaks sol2 with luajit

No. luajit wasn't a dependency of sol2.

The old behavior that resulted in an error is imho the right thing to do.

No.

@pfirsich
Copy link

sol2 depends on a Lua implementation. Officially supported are PUC Lua, LuaJIT and MoonJIT. I would say lua is not any more a dependency of sol2 than luajit is. sol2 just needs one (any) of them and I think it should be supported to use sol2 with any of them when installed through vcpkg.

@dg0yt
Copy link
Contributor

dg0yt commented May 29, 2023

Keep the discussion in #31702.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants