Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stlab] update to v1.4.1 #6209

Merged
merged 2 commits into from
Apr 26, 2019
Merged

[stlab] update to v1.4.1 #6209

merged 2 commits into from
Apr 26, 2019

Conversation

kypp
Copy link
Contributor

@kypp kypp commented Apr 25, 2019

  • update stlab from 1.3.3 to 1.4.1
  • update head reference to develop - the active development branch

[stlab] update head reference
@grdowns grdowns self-assigned this Apr 25, 2019
@Rastaban
Copy link
Contributor

I am seeing failures on x64-OSX with this update. Are you able to investigate those?

@Rastaban
Copy link
Contributor

Rastaban commented Apr 25, 2019

It looks like it might be failing due to a missing dependency to the boost unit test framework
config-x64-osx-dbg-err.log
Although DBUILD_TESTING=OFF, so it probably should not be worrying about that dependancy.

@grdowns
Copy link
Contributor

grdowns commented Apr 25, 2019

It's due to Mac having a dependency on boost-optional and boost-variant with this update -- not the tests. See the code block at CMakeLists.txt:128

@grdowns
Copy link
Contributor

grdowns commented Apr 25, 2019

Adding these dependencies to the CONTROL file as Build-Depends: boost-optional (osx), boost-variant (osx) should fix this update for Mac

@kypp
Copy link
Contributor Author

kypp commented Apr 26, 2019

Thanks for the input - it appears only boost-variant is obligatory on Mac, but an additional patch was needed to exclude tests as using anything from boost implied them.

I've updated the PR with those changes

@grdowns
Copy link
Contributor

grdowns commented Apr 26, 2019

Thanks for getting to the bottom of this, @kypp! Everything looks good

@grdowns grdowns merged commit dad8307 into microsoft:master Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants