Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cppmicroservices] Add new port (fix #5801) #6388

Merged
merged 5 commits into from
Jul 6, 2019

Conversation

saschazelzer
Copy link
Contributor

I tested this port on Windows using

x86-windows
x86-windows-static
x64-windows
x64-windows-static

and Linux (Fedora 29)

x64-linux
x64-linux-static

I do not have access to a Windows ARM platform though.

@msftclas
Copy link

msftclas commented May 10, 2019

CLA assistant check
All CLA requirements met.

@NancyLi1013
Copy link
Contributor

Hi @saschazelzer, thanks for the new port. I see some failures from the current CI system:

x64-osx master test notes
cppmicroservices Fail New Port
arm64-windows master test notes
cppmicroservices Fail New Port
x64-uwp master test notes
cppmicroservices Fail New Port
arm-uwp master test notes
cppmicroservices Fail New Port

Please refer to the following attachment to see what happended on these triplets.
failureLogs.zip

x64-windows-static results are inconclusive because it is missing logs from test
As for x64-windows-static, we get some exception info like this:

-- Performing post-build validation
Running command:
"C:\VS2017\Stable\VC\Tools\MSVC\14.16.27023\bin\HostX86\x86\dumpbin.exe" /directives "C:\vsts_work\2\s\packages\cppmicroservices_x64-windows-static\debug\lib\CppMicroServices4d.lib"
failed with message:
Microsoft (R) COFF/PE Dumper Version 14.16.27026.1
Dump of file C:\vsts_work\2\s\packages\cppmicroservices_x64-windows-static\debug\lib\CppMicroServices4d.lib

C:\vsts_work\2\s\packages\cppmicroservices_x64-windows-static\debug\lib\CppMicroServices4d.lib : fatal error LNK1107: invalid or corrupt file: cannot read at 0x9EA2F92

@vicroms
Copy link
Member

vicroms commented May 17, 2019

/AzurePipelines run

@dan-shaw
Copy link
Contributor

/azp run

@dan-shaw
Copy link
Contributor

/azp run

@dan-shaw dan-shaw merged commit 1000d82 into microsoft:master Jul 6, 2019
@dan-shaw
Copy link
Contributor

dan-shaw commented Jul 6, 2019

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants