Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libmysql]Fix build error in linux. #6442

Merged
merged 3 commits into from
Jun 11, 2019
Merged

[libmysql]Fix build error in linux. #6442

merged 3 commits into from
Jun 11, 2019

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented May 14, 2019

The reason for the build error in linux is that the macro CMAKE_SYSTEM_PROCESSOR is NOT set. So I modified the configure.cmake file.
Building libmysql in linux requires ncurses support(Which is not included in vcpkg), so I wrote a warning output in portfile.cmake. WARNING: It may cause CI build error.

And thanks @scttgs0 for his patch.

Related: #4616 #6389 #5046 #4409 #6365

@JackBoosY JackBoosY added the info:internal This PR or Issue was filed by the vcpkg team. label May 14, 2019
@vicroms
Copy link
Member

vicroms commented May 14, 2019

Also related: #5218

@vicroms
Copy link
Member

vicroms commented May 16, 2019

/AzurePipelines run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@vicroms
Copy link
Member

vicroms commented May 16, 2019

Necessary dependencies where not installed in CI, they are now, so I'm triggering a new build.

The problem with this one, is that a ✔️ means that there are not regressions, NOT that the port is building successfully for x64-linux . So we have to be careful to merge it.

@JackBoosY
Copy link
Contributor Author

/bin/bash failed with return code: 2
return code: 1


fi
[command]/bin/bash /Users/philc/vcpkg/myagent/_work/7/s/user_script.sh
/Users/philc/vcpkg/myagent/_work/7/s/user_script.sh: line 4: syntax error near unexpected token `fi'
/Users/philc/vcpkg/myagent/_work/7/s/user_script.sh: line 4: `fi'
##[section]Finishing: Setup Environment

Why?

@JackBoosY
Copy link
Contributor Author

@Rastaban Can you look at it? PR-EAGER is blocked on the OSX step.

@JackBoosY JackBoosY requested a review from Rastaban May 31, 2019 09:54
@Rastaban Rastaban merged commit 59a8a9c into microsoft:master Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants