Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[soxr] Add new port #6478

Merged
merged 8 commits into from
Jul 2, 2019
Merged

[soxr] Add new port #6478

merged 8 commits into from
Jul 2, 2019

Conversation

ThijsWithaar
Copy link
Contributor

Request to add the soxr library, see also #3557.

@msftclas
Copy link

msftclas commented May 16, 2019

CLA assistant check
All CLA requirements met.

@NancyLi1013
Copy link
Contributor

Hi @ThijsWithaar, thanks for the new port. Here are the test results from the current CI system:

x64-osx master test notes
soxr Fail New Port
arm64-windows master test notes
soxr Fail New Port
x64-linux master test notes
soxr Fail New Port
x64-uwp master test notes
soxr Fail New Port
arm-uwp master test notes
soxr Fail New Port

failureLogs.zip

Copy link
Contributor

@MVoz MVoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm...

"Build type, one of: None Debug Release RelWithDebInfo MinSizeRel." FORCE)
endif ()

-option (BUILD_TESTS "Build sanity-tests." ON)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also easier through the port file

vcpkg_configure_cmake(
SOURCE_PATH ${SOURCE_PATH}
PREFER_NINJA
OPTIONS
-DBUILD_TESTS=OFF
-DWITH_OPENMP=OFF
-DWITH_LSR_BINDINGS=OFF

....

@ThijsWithaar
Copy link
Contributor Author

Ok, update to use cmake settings instead of a path. It seems I still have a warning:

CMake Warning at C:/vsts/_work/7/s/scripts/buildsystems/vcpkg.cmake:107 (message):
  There are no libraries installed for the Vcpkg triplet arm64-windows.

And an error which needs addressing:

vector-gen.exe is not compatible with the version of Windows you're running. Check your computer's system information and then contact the software publisher.

It does build fine on my machine, so I'm not completely sure what's going on.

Is it obvious for you what's going on ?

@grdowns
Copy link
Contributor

grdowns commented Jul 2, 2019

/azp run

@grdowns
Copy link
Contributor

grdowns commented Jul 2, 2019

Thanks for the new port, @ThijsWithaar!

@grdowns grdowns merged commit 2291b2f into microsoft:master Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants