-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ffmpeg] fix link debug bzip2 #6570
[ffmpeg] fix link debug bzip2 #6570
Conversation
/azp run |
@cbezault, this doesn't seem to work. I'm trying to build
Your patch does not get applied:
Here's the contents of
Debug configuration fails to build:
Here's the contents of
|
Hmmm, I managed to get it to build on my system I'll fix this issue asap (today). Edit: Ah, I made an embarrassing mistake. I checked out the version of vcpkg that #4250 was based on (or older) and used the changes from that PR as my starting point, and obviously a newer version of ffmpeg is being used now, so the patch fails. The CI did not fail because it only attempts to build the default features of a port. I think @cenit made a suggestion concerning failing on failed patch application that would have caught this in the CI. This makes me more inclined to agree with his take that failure to apply a patch should be a build failure. |
@cbezault yes that’s the goal of #6578. It’s necessary to finish it before transforming the status message into a fatal_error one, otherwise many ports would fail. It was not designed as a fatal error since the beginning only because vcpkg was missing some source-recycling mechanisms. Now that they are available, I think it’s better to move to fail. Many mistakes and problems would be avoided, with no counter problem afaik |
@emptyVoid we're going to be making a change to bzip so that we don't add the "d" suffix, once that is done I'll submit a PR that should add bzip2 support on windows and all other platforms. |
Closes #4250