Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[munit] Add new port #6780

Merged
merged 18 commits into from
May 19, 2020
Merged

[munit] Add new port #6780

merged 18 commits into from
May 19, 2020

Conversation

myd7349
Copy link
Contributor

@myd7349 myd7349 commented Jun 5, 2019

No description provided.

@myd7349
Copy link
Contributor Author

myd7349 commented Jul 4, 2019

#7150

ports/munit/CONTROL Outdated Show resolved Hide resolved
ports/munit/portfile.cmake Outdated Show resolved Hide resolved
ports/munit/portfile.cmake Outdated Show resolved Hide resolved
@JackBoosY
Copy link
Contributor

/azp run

@JackBoosY
Copy link
Contributor

Please fix build failures.

@LilyWangL
Copy link
Contributor

Pinging @myd7349 for response. Is work still being done for this PR?

@LilyWangL
Copy link
Contributor

Thanks for your PR. Please add supports to CONTROL. And please use vcpkg_fail_port_install in portfile.cmake to description this port doesn't support some triplets.

@LilyWangL
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@LilyWangL
Copy link
Contributor

@myd7349 Thanks for your PR. Now this port build failed on triplet x64_uwp arm64_windows arm_uwp x64_osx x64_linux, if this port doesn't support these triplet. Can you use Supports and vcpkg_fail_port_install to description this port doesn't support some triplets. And please modify VCPKG_PATH/scripts/ci.baseline.txt to account for the build failures on unsupported triplets.

@LilyWangL LilyWangL marked this pull request as ready for review May 13, 2020 05:59
@LilyWangL LilyWangL added info:reviewed Pull Request changes follow basic guidelines and removed waiting for response labels May 13, 2020
@strega-nil strega-nil added depends:vm-update PR contains changes to the VM provisioning scripts and removed depends:vm-update PR contains changes to the VM provisioning scripts labels May 15, 2020
Copy link
Contributor

@strega-nil strega-nil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After adding the find_acquire_program, you should be able to run on x64-linux and x64-osx

ports/munit/portfile.cmake Show resolved Hide resolved
@strega-nil strega-nil added waiting for response and removed info:reviewed Pull Request changes follow basic guidelines labels May 15, 2020
@JackBoosY
Copy link
Contributor

Does this port support Linux / OSX ?

@myd7349
Copy link
Contributor Author

myd7349 commented May 19, 2020

x64-linux:

-- Downloading https://github.com/nemequ/munit/archive/da8f73412998e4f1adf1100dc187533a51af77fd.tar.gz...
-- Extracting source /mnt/1/s/downloads/nemequ-munit-da8f73412998e4f1adf1100dc187533a51af77fd.tar.gz
-- Applying patch fix-install.patch
-- Using source at /mnt/1/s/buildtrees/munit/src/3a51af77fd-8670ab3989
CMake Error at scripts/cmake/vcpkg_find_acquire_program.cmake:367 (message):
  Could not find meson.  Please install it via your package manager:

      sudo apt-get install meson
Call Stack (most recent call first):
  scripts/cmake/vcpkg_configure_meson.cmake:94 (vcpkg_find_acquire_program)
  ports/munit/portfile.cmake:15 (vcpkg_configure_meson)
  scripts/ports.cmake:90 (include)

x64-osx:

  File "/usr/local/bin/meson", line 2
    PYTHONPATH="/usr/local/Cellar/meson/0.54.1_2/lib/python3.8/site-packages" exec "/usr/local/Cellar/meson/0.54.1_2/libexec/bin/meson" "$@"
                                                                                 ^
SyntaxError: invalid syntax

I do not have a macbook at hand, so I can not figure out what happened to x64-osx. I am able to install munit on a virtual machine with CentOS which has meson pre-installed.

I can not figure out a good solution currently, so I will disable them.

@strega-nil
Copy link
Contributor

Alright, thanks @myd7349 :)

@strega-nil strega-nil merged commit 3864f7b into microsoft:master May 19, 2020
@myd7349 myd7349 deleted the munit-init branch May 20, 2020 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants