Cleanup vcpkg_configure_cmake.cmake #6792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup code.
* Remove/fix possibly redundant call to `vcpkg_find_acquire_program()`, thus setting `PATH` twice
* Fix accessing `ENV{PROCESSOR_ARCHITECTURE}`, which is Windows only
* Use `macro()`s to improve readability.
* Use variables to reduce redundant checks and increase clarity
Rastaban
reviewed
Jun 7, 2019
|
Overall this looks like a good improvement to the readability of the file. Changes to this file do not yet trigger a full build in the PR test system when the build pipelines run so we will want to run some additional tests for verification. |
|
resolved merge conflicts |
|
Running full rebuild test 6792c https://dev.azure.com/vcpkg/public/_build/results?buildId=4906 |
|
This looks good, the only test failures in the full rebuild were unrelated to this change (some ports can be flaky) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup code.
vcpkg_find_acquire_program(), thus settingPATHtwiceENV{PROCESSOR_ARCHITECTURE}, which is Windows onlymacro()s to improve readability.