Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zookeeper-mt] Add new port #7000

Merged
merged 8 commits into from
Jul 6, 2019
Merged

Conversation

SamuelMarks
Copy link
Contributor

@SamuelMarks SamuelMarks commented Jun 23, 2019

Apache ZooKeeper is a centralized service for maintaining configuration information, naming, providing distributed synchronization, and providing group services.

EDIT: WOOT: 7000!

@SamuelMarks SamuelMarks mentioned this pull request Jun 23, 2019
@dan-shaw
Copy link
Contributor

dan-shaw commented Jul 5, 2019

@SamuelMarks Thanks for the PR! I've made some changes:

  1. Added support for zookeeper_st shared library (it's the zookeeper[async] feature). However, by default zookeeper_mt is installed. I've also changed the name from zookeeper-mt to zookeeper since we now support both libraries.
  2. I've made it into a static library since zookeeper doesn't support BUILD_SHARED_LIBS yet
  3. I've also refactored some of the cmake

Let me know if I missed anything.

ports/zookeeper/CONTROL Outdated Show resolved Hide resolved
ports/zookeeper/portfile.cmake Show resolved Hide resolved
@dan-shaw dan-shaw merged commit 8c64785 into microsoft:master Jul 6, 2019
@dan-shaw
Copy link
Contributor

dan-shaw commented Jul 6, 2019

Thanks for the PR!

@SamuelMarks SamuelMarks deleted the add-zookeeper-c branch July 10, 2019 01:07
@NancyLi1013 NancyLi1013 mentioned this pull request Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants