Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scnlib] Add new port #7014

Merged
merged 2 commits into from
Jul 16, 2019
Merged

[scnlib] Add new port #7014

merged 2 commits into from
Jul 16, 2019

Conversation

SuperWig
Copy link
Contributor

@SuperWig SuperWig commented Jun 24, 2019

The support for range-v3 doesn't work with the fork vcpkg has so I disabled it.

Edit: Now realising that vcpkg doesn't use the Microsoft fork as indicated by the control file.

@SuperWig
Copy link
Contributor Author

I'm unfamiliar with UWP but I assume the library doesn't support it?
Should the description include (pre-release) in it?

@SuperWig SuperWig marked this pull request as ready for review June 25, 2019 08:36
@eliaskosunen
Copy link

Thanks for doing this; I don't know vcpkg, so it's good that someone knowledgeable would do this for me.

Couple of points:

  • Version should be 0.1.2, and the head reference should be updated
  • Homepage should be https://scnlib.dev
  • To disable the ranges target, set -DSCN_RANGES=OFF instead of -DCMAKE_DISABLE_FIND_PACKAGE

I don't know about the UWP error; that's just a warning on Appveyor on Windows. Maybe do what abseil does:

if(VCPKG_CMAKE_SYSTEM_NAME STREQUAL "WindowsStore")
message(FATAL_ERROR "Abseil currently only supports being built for desktop")
endif()

WindowsStore is UWP, right?

@SuperWig
Copy link
Contributor Author

SuperWig commented Jun 26, 2019

Thanks, updated!
I didn't realise that the logs were accessible. Apparently the UWP build fails because of this

visitor.cpp(517): error C4146: unary minus operator applied to unsigned type, result still unsigned

Curious as to why this is treated as an error for UWP but not x86?

And thank you for the library :)

@Rastaban
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Rastaban Rastaban merged commit e024dd7 into microsoft:master Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants