[vcpkg] Fix powershell font corruption bug #7094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ras0219-msft
added
the
info:internal
strega-nil
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
* [vcpkg] Fix font corruption bug on Windows by downloading Powershell Core * [vcpkg] Rename subtool to powershell-core * [vcpkg] Add missing includes to project files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All in-box versions of powershell in Windows 7 through Windows 10 will corrupt the console font in certain (common) circumstances[1]. The best way to fix this is to always use the new powershell core, which has removed this "feature".
As an added bonus, it means any powershell scripts inside vcpkg can rely on having a modern version of powershell and don't need to worry about version skew across legacy Windows versions (Note: does not apply to bootstrap.ps1 and applocal.ps1 because these run outside vcpkg).
[1] PowerShell/PowerShell@46cdd7e#diff-38052b6d0f2182bf2d4debed33df29f6L2665