ITK portfile support legacy user code by default #7241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzenanz
approved these changes
Jul 11, 2019
|
Is there anything more I could do to get this very small pull request accepted? @dzenanz ? |
|
I have a feeling that vcpkg maintainers merge PRs in waves. Otherwise you could try pinging the few people who usually do merges. |
|
Could you also bump the CONTROL version to |
No longer specify `ITK_LEGACY_REMOVE` and `ITK_FUTURE_LEGACY_REMOVE` options for `vcpkg_configure_cmake`. By default, these two flags are `OFF`, for ITK 5.0.0: https://github.com/InsightSoftwareConsortium/ITK/blob/v5.0.0/CMakeLists.txt#L261 This commit will allow legacy ITK user code to build with vcpkg, and it will ease adding vcpkg support to https://github.com/SuperElastix/elastix Dženan Zukić @dzenanz suggested this change: https://discourse.itk.org/t/how-to-avoid-rebuilding-itk-by-azure-ci-at-the-github-of-another-project-elastix/2002/7 CONTROL version bumped as requested by Phil Christensen @Rastaban
|
|
Thanks for your suggestion, Phil. I just amended the commit of this pull request to include the version bump. Please consider merging! |
|
Wow, sorry this took so long. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer specify
ITK_LEGACY_REMOVEandITK_FUTURE_LEGACY_REMOVEoptions for
vcpkg_configure_cmake. By default, these two flags areOFF, for ITK 5.0.0:https://github.com/InsightSoftwareConsortium/ITK/blob/v5.0.0/CMakeLists.txt#L261
This commit will allow legacy ITK user code to build with vcpkg, and it
will ease adding vcpkg support to https://github.com/SuperElastix/elastix
Dženan Zukić @dzenanz suggested this change:
https://discourse.itk.org/t/how-to-avoid-rebuilding-itk-by-azure-ci-at-the-github-of-another-project-elastix/2002/7
CONTROL version bumped as requested by Phil Christensen @Rastaban