Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libsodium] Fix Linux build error. #7297

Merged
merged 1 commit into from
Jul 17, 2019

Conversation

NancyLi1013
Copy link
Contributor

When building on Linux, there are some errors like this:

cc: error: unrecognized command option ‘-Wduplicated-branches’
cc: error: unrecognized command line option ‘-Wduplicated-cond’
cc: error: unrecognized command line option ‘-Wmisleading-indentation’
cc: error: unrecognized command line option ‘-Wnull-dereference’
cc: error: unrecognized command line option ‘-Wrestrict’

So I fix it by removing these command options in CMakeLists.txt.

@NancyLi1013 NancyLi1013 added the info:internal This PR or Issue was filed by the vcpkg team. label Jul 17, 2019
@Rastaban
Copy link
Contributor

It looks like these options are all available in gcc but not in Clang. They should be okay to remove.

@Rastaban Rastaban merged commit 709e042 into microsoft:master Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants