[vcpkg] Fix RealFilesystem::remove_all #7430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strega-nil
force-pushed
the
fix-remove-all
branch
from
69525f4
to
1c84b4a
Compare
we were attempting to remove READONLY files before this, and so set them to non-READONLY
strega-nil
force-pushed
the
fix-remove-all
branch
from
1c84b4a
to
d483b45
Compare
|
Working on installing VS2015 so I can also fix #7405 |
|
Yes, this (adding VS2015 coverage to CI) is on our backlog. |
strega-nil
added a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
* fix remove_all we were attempting to remove READONLY files before this, and so set them to non-READONLY * fix linux/macos support * whee fix vs2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we were attempting to remove READONLY files before this, and so set them to non-READONLY
TODO: add readonly to some files in the tests
Fixes #7405