-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[liblzma] Fix build failure #7481
Conversation
Could you also bump the CONTROL version to |
But if you build both configs (like in a default triplet), then what happens? Is the overwrite clean? |
Tesseract is only failed port here, it's not related to Alvin’s change, it also failed on master branch. Tesseract failed due to support libarchive in version 4.1, but lacking of dependency libraries(bzip2, Lz4, libxml2, openssl, lzo), after libarchive installed, tessarct find installed/x64-linux/debug/lib/libarchive.a, but can’t find its dependency. Summit PR #7613 to fix it. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
@AlvinZhangH , the CI on OSX failed, please remove quantlib:x64-os from ci.baseline.txt ##[error] PASSING, REMOVE FROM FAIL LIST: quantlib:x64-osx (/Users/vagrant/azure-agent/_work/2/s/scripts/ci.baseline.txt) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the PR! @cenit |
* fix 7426 issue * fix 7426 issue -change the CONTROL file * [liblzma] Remove quantlib:x64-os from ci.baseline.txt * [liblzma] Update the CONTROL version
User add
set(VCPKG_BUILD_TYPE debug)
in custom triplet, however, in liblzma portfile, it usefile(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/debug/include)
, and it doesn’t copy headers to installed/triplet/include folder.So post-build validation failed, the folder include is not present:
Change
file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/debug/include)
To
Relate: #7426.