Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[angelscript] Added feature to optionally install all Angelscript standard addons #7650

Merged
merged 1 commit into from Aug 16, 2019

Conversation

adam4813
Copy link
Contributor

Adds a feature to install the standard addons alongside the angelscript library that can be linked by the consumer of the library.

For those searching how to consume these addons in the future, simply create a .cpp file that contains the following:

#include <angelscript/scriptstdstring/scriptstdstring.cpp>
#include <angelscript/scriptbuilder/scriptbuilder.cpp>
...

and compile that source file into whatever you are building (you only need to compile in the .cpp files).

See here official sdk for a list of addons. Autowrappper generator might not be useful to consume.

The full list of installed addon files is below

angelscript/autowrapper/aswrappedcall.h
angelscript/autowrapper/generator/generateheader.cpp
angelscript/contextmgr/contextmgr.cpp
angelscript/contextmgr/contextmgr.h
angelscript/datetime/datetime.cpp
angelscript/datetime/datetime.h
angelscript/debugger/debugger.cpp
angelscript/debugger/debugger.h
angelscript/scriptany/scriptany.cpp
angelscript/scriptany/scriptany.h
angelscript/scriptarray/scriptarray.cpp
angelscript/scriptarray/scriptarray.h
angelscript/scriptbuilder/scriptbuilder.cpp
angelscript/scriptbuilder/scriptbuilder.h
angelscript/scriptdictionary/scriptdictionary.cpp
angelscript/scriptdictionary/scriptdictionary.h
angelscript/scriptfile/scriptfile.cpp
angelscript/scriptfile/scriptfile.h
angelscript/scriptfile/scriptfilesystem.cpp
angelscript/scriptfile/scriptfilesystem.h
angelscript/scriptgrid/scriptgrid.cpp
angelscript/scriptgrid/scriptgrid.h
angelscript/scripthandle/scripthandle.cpp
angelscript/scripthandle/scripthandle.h
angelscript/scripthelper/scripthelper.cpp
angelscript/scripthelper/scripthelper.h
angelscript/scriptmath/scriptmath.cpp
angelscript/scriptmath/scriptmath.h
angelscript/scriptmath/scriptmathcomplex.cpp
angelscript/scriptmath/scriptmathcomplex.h
angelscript/scriptstdstring/scriptstdstring.cpp
angelscript/scriptstdstring/scriptstdstring.h
angelscript/scriptstdstring/scriptstdstring_utils.cpp
angelscript/serializer/serializer.cpp
angelscript/serializer/serializer.h
angelscript/weakref/weakref.cpp
angelscript/weakref/weakref.h

@adam4813 adam4813 marked this pull request as ready for review August 11, 2019 23:29
@vicroms
Copy link
Member

vicroms commented Aug 13, 2019

Hi @adam4813

Thanks for the PR!

I have a question: wouldn't it be useful to have a feature for each add-on?

That way users can install only the ones they need (e.g.: vcpkg install angelscript[serializer]), and if they want them all then they can do vcpkg install angelscript[*].

@vicroms vicroms self-assigned this Aug 13, 2019
@vicroms vicroms merged commit 0a03325 into microsoft:master Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants