Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[openssl] Update openssl to 1.1.1d #8142

Closed
wants to merge 13 commits into from
Closed

[openssl] Update openssl to 1.1.1d #8142

wants to merge 13 commits into from

Conversation

fcharlie
Copy link
Contributor

@fcharlie fcharlie commented Sep 12, 2019 •
edited

This PR will upgrade vcpkg openssl to 1.1.1d and may not consider openssl-uwp. In any case, this work is still in progress.

Since openssl is dependent on many libraries, this PR faces more difficulties.

OS OpenSSL Version Details
Windows Desktop 1.1.1d build ok, other ports no test
Windows UWP 1.1.1d build ok. other ports no test
Unix 1.1.1d grpc ok, curl ok.

Ports that need to be upgraded:

  • libpq
  • libssh

reference: #4267

@fcharlie fcharlie changed the title [ports] Update openssl to 1.1.1c [ports] Update openssl to 1.1.1d Sep 12, 2019
@cbezault cbezault assigned cbezault and unassigned grdowns Sep 12, 2019
@cbezault cbezault changed the title [ports] Update openssl to 1.1.1d [openssl] Update openssl to 1.1.1d Sep 12, 2019
@fcharlie
Copy link
Contributor Author

After many attempts, uwp-x64 was built successfully.

image

@fcharlie fcharlie mentioned this pull request Sep 13, 2019
Closed
@illera88
Copy link
Contributor

How is this going?

@cbezault
Copy link
Contributor

Slowly but we'll be done before the end of the year.

@cbezault
Copy link
Contributor

/azp run

@fcharlie
Copy link
Contributor Author

@illera88 Since openssl is dependent on many other ports, there may be more ports that need to be fixed, which requires the help of others.

@cbezault cbezault assigned grdowns and unassigned cbezault Oct 2, 2019
@vicroms
Copy link
Member

vicroms commented Oct 8, 2019

/azp run

@azure-pipelines
Copy link

Pull request contains merge conflicts.

@microsoft microsoft deleted a comment from azure-pipelines bot Oct 8, 2019
@fcharlie
Update CONTROL
9d89953 
Fix version
@Neumann-A
Copy link
Contributor

@fcharlie do you know what is going on with uwp builds? If I do dumpbin libcrypto.lib /SYMBOLS i dont see any symbols
Also #8566 fixes most regression except for the UWP ones which might be false positives in the sense that those ports should never worked in UWP in the first place.

@fcharlie
Copy link
Contributor Author

@Neumann-A try dumpbin libcrypto.lib /EXPORTS ?

@ras0219-msft
Copy link
Contributor

/azp run

@fcharlie
Copy link
Contributor Author

@ras0219-msft Maybe you should try to accept another PR #8566

@JackBoosY
Copy link
Contributor

/azp run

@fcharlie
Copy link
Contributor Author

fcharlie commented Jan 7, 2020

The purpose of this PR is to throw out a brick to attract a jade, and the purpose has been achieved, so it is closed. Thanks #8566

@fcharlie fcharlie closed this Jan 7, 2020
@fcharlie fcharlie deleted the openssl branch January 14, 2020 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vicroms vicroms

@ras0219-msft ras0219-msft

@grdowns grdowns

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@fcharlie @illera88 @cbezault @vicroms @Neumann-A @ras0219-msft @JackBoosY @grdowns @jwillemsen