Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kfr] Add new port #8322

Merged
merged 9 commits into from
Jul 9, 2020
Merged

[kfr] Add new port #8322

merged 9 commits into from
Jul 9, 2020

Conversation

myd7349
Copy link
Contributor

@myd7349 myd7349 commented Sep 24, 2019

No description provided.

@myd7349 myd7349 marked this pull request as ready for review October 8, 2019 00:27
@LilyWangL
Copy link
Contributor

/azp run

ports/kfr/portfile.cmake Outdated Show resolved Hide resolved
ports/kfr/portfile.cmake Outdated Show resolved Hide resolved
@LilyWangL
Copy link
Contributor

Pinging @myd7349 for response. Is work still being done for this PR?

@LilyWangL
Copy link
Contributor

Closing this PR since it seems that no progress is being made. Please reopen if work is still being done.

@LilyWangL LilyWangL closed this May 7, 2020
@myd7349
Copy link
Contributor Author

myd7349 commented Jun 15, 2020

Hi! @LilyWangL Sorry for the long delay.
I have finished all my other PRs and I think it is time to pick this one up. But I am not able to reopen it.
Can you help me reopen it? Thanks.

@LilyWangL
Copy link
Contributor

Hi! @LilyWangL Sorry for the long delay.
I have finished all my other PRs and I think it is time to pick this one up. But I am not able to reopen it.
Can you help me reopen it? Thanks.

Done.

@LilyWangL LilyWangL added category:new-port The issue is requesting a new library to be added; consider making a PR! and removed requires:author-response labels Jun 16, 2020
@LilyWangL
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LilyWangL
Copy link
Contributor

Hi, @myd7349 Now kfr build failed on Linux with the following error:

/mnt/vcpkg-ci/buildtrees/kfr/src/70ebd9a223-37f5ac66e1/include/kfr/io/impl/../../base/../simd/impl/../../base/../simd/impl/backend_generic.hpp:653:72: error: macro "_mm256_shuffle_ps" passed 7 arguments, but takes just 3
     return _mm256_shuffle_ps(t1, t2, shuffle_mask<8, 2, 3, 2, 3>::value);
                                                                        ^
/mnt/vcpkg-ci/buildtrees/kfr/src/70ebd9a223-37f5ac66e1/include/kfr/io/impl/../../base/../simd/impl/../../base/../simd/impl/backend_generic.hpp:661:72: error: macro "_mm256_shuffle_ps" passed 7 arguments, but takes just 3
     return _mm256_shuffle_ps(t1, t2, shuffle_mask<8, 0, 1, 0, 1>::value);
                                                                        ^
/mnt/vcpkg-ci/buildtrees/kfr/src/70ebd9a223-37f5ac66e1/include/kfr/io/impl/../../base/../simd/impl/../../base/../simd/impl/backend_generic.hpp:1655:82: error: macro "_mm256_shuffle_ps" passed 7 arguments, but takes just 3
             return _mm256_shuffle_ps(x, x, shuffle_mask<8, I0, I1, I2, I3>::value);
                                                                                  ^
/mnt/vcpkg-ci/buildtrees/kfr/src/70ebd9a223-37f5ac66e1/include/kfr/io/impl/../../base/../simd/impl/../../base/../simd/impl/backend_generic.hpp:1676:75: error: macro "_mm256_blend_ps" passed 11 arguments, but takes just 3
                                             1 - I6 / 4, 1 - I7 / 4>::value);
                                                                           ^

@myd7349
Copy link
Contributor Author

myd7349 commented Jun 30, 2020

Hi, @myd7349 Now kfr build failed on Linux with the following error:

/mnt/vcpkg-ci/buildtrees/kfr/src/70ebd9a223-37f5ac66e1/include/kfr/io/impl/../../base/../simd/impl/../../base/../simd/impl/backend_generic.hpp:653:72: error: macro "_mm256_shuffle_ps" passed 7 arguments, but takes just 3
     return _mm256_shuffle_ps(t1, t2, shuffle_mask<8, 2, 3, 2, 3>::value);
                                                                        ^
/mnt/vcpkg-ci/buildtrees/kfr/src/70ebd9a223-37f5ac66e1/include/kfr/io/impl/../../base/../simd/impl/../../base/../simd/impl/backend_generic.hpp:661:72: error: macro "_mm256_shuffle_ps" passed 7 arguments, but takes just 3
     return _mm256_shuffle_ps(t1, t2, shuffle_mask<8, 0, 1, 0, 1>::value);
                                                                        ^
/mnt/vcpkg-ci/buildtrees/kfr/src/70ebd9a223-37f5ac66e1/include/kfr/io/impl/../../base/../simd/impl/../../base/../simd/impl/backend_generic.hpp:1655:82: error: macro "_mm256_shuffle_ps" passed 7 arguments, but takes just 3
             return _mm256_shuffle_ps(x, x, shuffle_mask<8, I0, I1, I2, I3>::value);
                                                                                  ^
/mnt/vcpkg-ci/buildtrees/kfr/src/70ebd9a223-37f5ac66e1/include/kfr/io/impl/../../base/../simd/impl/../../base/../simd/impl/backend_generic.hpp:1676:75: error: macro "_mm256_blend_ps" passed 11 arguments, but takes just 3
                                             1 - I6 / 4, 1 - I7 / 4>::value);
                                                                           ^

Hi! @LilyWangL Thanks. I will try to fix it.

@LilyWangL LilyWangL added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jul 7, 2020
@ras0219-msft ras0219-msft merged commit dbba608 into microsoft:master Jul 9, 2020
@ras0219-msft
Copy link
Contributor

LGTM, thanks for the PR!

@soulthreads
Copy link

Here's a problem: KFR doesn't compile with MSVC compiler if you enable DFT: kfrlib/kfr#70

Not sure if there is even a way to do this in vcpkg, but it needs to be built with clang-cl compiler on Windows.

@myd7349 myd7349 deleted the kfr-init branch July 13, 2020 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants