Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[uchardet] Add new port #8477

Merged
merged 10 commits into from
Apr 28, 2020
Merged

[uchardet] Add new port #8477

merged 10 commits into from
Apr 28, 2020

Conversation

myd7349
Copy link
Contributor

@myd7349 myd7349 commented Oct 7, 2019

Related issue: #8088 .

@vicroms
Copy link
Member

vicroms commented Oct 9, 2019

UWP failures

CMake Error at CMakeLists.txt:42 (string):
  string no output variable specified

myd7349
myd7349 commented Oct 10, 2019
View reviewed changes
ports/uchardet/CONTROL Outdated Show resolved Hide resolved
@myd7349
Copy link
Contributor Author

myd7349 commented Oct 10, 2019 •
edited
Loading

UWP failures

CMake Error at CMakeLists.txt:42 (string):
  string no output variable specified

Hi! @vicroms Thanks for your kindly help!

@myd7349 myd7349 marked this pull request as ready for review October 10, 2019 10:38
@JackBoosY
Copy link
Contributor

/azp run

@LilyWangL
Copy link
Contributor

/azp run

LilyWangL
LilyWangL suggested changes Jan 21, 2020
View reviewed changes
ports/uchardet/portfile.cmake Outdated Show resolved Hide resolved
ports/uchardet/portfile.cmake Outdated Show resolved Hide resolved
@JackBoosY
Copy link
Contributor

Seems build failure on uwp, can you check that?

Thanks.

@MVoz MVoz mentioned this pull request Mar 21, 2020
Closed
@LilyWangL LilyWangL added the info:reviewed Pull Request changes follow basic guidelines label Apr 28, 2020
@strega-nil
Copy link
Contributor

Alright, looks good! Thanks again @myd7349 :)

@strega-nil strega-nil merged commit be2f81f into microsoft:master Apr 28, 2020
@myd7349 myd7349 deleted the uchardet-init branch April 29, 2020 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LilyWangL LilyWangL LilyWangL approved these changes

Assignees

@grdowns grdowns

@LilyWangL LilyWangL

Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@myd7349 @vicroms @JackBoosY @LilyWangL @strega-nil @grdowns