New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added OIS port #8507
Added OIS port #8507
Conversation
So it looks like the build is failing with:
I'm trying to figure out if there's a missing dependency. According to the github page windows builds depend on |
latest winsdk 10.0.17133.0 delete ? https://github.com/wgois/OIS/blob/master/CMakeModules/FindWindowsSDK.cmake two lib files if (WINDOWSSDK_FOUND) |
@vpaladino778, CI vcpkg-windows-PR failed, add code as follow can solved: |
Hello! Thanks for your reply. I added the lines you mentioned but it looks like it's still failing on windows for some reason. |
Does this port support arm/uwp? |
@JackBoosY I've opened up an issue on the OIS github page to check. In the meantime, should i add two |
@vpaladino778 Yep, If OIS doesn't support these arch, you need to add |
vcpkg_install_cmake() | ||
|
||
if(VCPKG_LIBRARY_LINKAGE STREQUAL static) | ||
file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/bin ${CURRENT_PACKAGES_DIR}/debug/bin) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which files will be generated here?
@voskrese CI has problem, we will fix it tomorrow. |
/azp run |
Created OIS Port. I wasn't sure if
vcpkg_fixup_cmake_targets
should be used here. When it's uncommented, it returned'C:/vcpkg/packages/ois_x86-windows/debug/lib/cmake/ois' does not exist
so i figured it wasn't necessary here.#8451