Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[openscap]Add new port. #8654

Merged
merged 5 commits into from
Oct 30, 2019
Merged

[openscap]Add new port. #8654

merged 5 commits into from
Oct 30, 2019

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Oct 18, 2019 •
edited
Loading

Since openscap dependency port glib(#8653) and libpopt(#8652) are not fixed, check windows build only.

Related: #6169.

@JackBoosY JackBoosY added the info:internal This PR or Issue was filed by the vcpkg team. label Oct 18, 2019
@JackBoosY JackBoosY marked this pull request as ready for review October 18, 2019 08:22
@MVoz
Copy link
Contributor

MVoz commented Oct 18, 2019

strange, I can not collect, errors

MSVC 2017

vcpkg install openscap[core,python,util]:x64-windows

oscap-tool.c.obj : error LNK2019: unresolved external symbol __imp_getopt_long_a referenced in function oscap_action_release
oscap-xccdf.c.obj : error LNK2001: unresolved external symbol __imp_getopt_long_a
oscap.c.obj : error LNK2001: unresolved external symbol __imp_getopt_long_a
oscap-cvrf.c.obj : error LNK2001: unresolved external symbol __imp_getopt_long_a
oscap-ds.c.obj : error LNK2001: unresolved external symbol __imp_getopt_long_a
oscap-info.c.obj : error LNK2001: unresolved external symbol __imp_getopt_long_a
oscap-oval.c.obj : error LNK2001: unresolved external symbol __imp_getopt_long_a
oscap-oval.c.obj : error LNK2019: unresolved external symbol __imp_optind referenced in function app_collect_oval
oscap-tool.c.obj : error LNK2001: unresolved external symbol __imp_optind
oscap-xccdf.c.obj : error LNK2001: unresolved external symbol __imp_optind
oscap-cvrf.c.obj : error LNK2001: unresolved external symbol __imp_optind
oscap-cvss.c.obj : error LNK2001: unresolved external symbol __imp_optind
oscap-ds.c.obj : error LNK2001: unresolved external symbol __imp_optind
oscap-info.c.obj : error LNK2001: unresolved external symbol __imp_optind
oscap-tool.c.obj : error LNK2001: unresolved external symbol __imp_optarg_a
oscap-xccdf.c.obj : error LNK2001: unresolved external symbol __imp_optarg_a
oscap-cvrf.c.obj : error LNK2001: unresolved external symbol __imp_optarg_a
oscap-ds.c.obj : error LNK2001: unresolved external symbol __imp_optarg_a
oscap-info.c.obj : error LNK2001: unresolved external symbol __imp_optarg_a
oscap-oval.c.obj : error LNK2001: unresolved external symbol __imp_optarg_a
oscap-tool.c.obj : error LNK2001: unresolved external symbol __imp_opterr

@JackBoosY
Copy link
Contributor Author

JackBoosY commented Oct 18, 2019 •
edited
Loading

@voskrese function getopt and optind should be used in Linux only. Why did you build failed?

Did you installed getopt-win32?

@MVoz
Copy link
Contributor

MVoz commented Oct 18, 2019 •
edited
Loading

I just updated the port, everything depends on today.

oscap.exe : fatal error <<-- [util] ?
oscap.exe : fatal error LNK1120: 4 unresolved externals

@JackBoosY
Copy link
Contributor Author

@voskrese
In SOURCE_PATH/CMakeLists.txt line 187:
check_include_file(getopt.h HAVE_GETOPT_H)

I think it should be related with this.

@MVoz
Copy link
Contributor

MVoz commented Oct 18, 2019 •
edited
Loading

vcpkg install openscap[core,python]:x64-windows [util] build ok

@JackBoosY
Copy link
Contributor Author

JackBoosY commented Oct 18, 2019 •
edited
Loading

@voskrese Thanks for figure that.

But after I installed libopt, I still cannot repro your failure.

@JackBoosY JackBoosY added the wip label Oct 18, 2019
@MVoz
Copy link
Contributor

MVoz commented Oct 18, 2019 •
edited
Loading

windows deps getopt-win32 ?

2019-10-18_182234

2019-10-18_181830

@MVoz
Copy link
Contributor

MVoz commented Oct 18, 2019 •
edited
Loading

add link lib getopt.lib, build ok

vcpkg install openscap[core,python,util]:x64-windows + util

      Found __imp_getopt_long_a
        Referenced in oscap-tool.c.obj
        Referenced in oscap-xccdf.c.obj
        Referenced in oscap.c.obj
        Referenced in oscap-cvrf.c.obj
        Referenced in oscap-ds.c.obj
        Referenced in oscap-info.c.obj
        Referenced in oscap-oval.c.obj
        Loaded getopt.lib(getopt.dll)
      Found __imp_optind
        Referenced in oscap-oval.c.obj
        Referenced in oscap-tool.c.obj
        Referenced in oscap-xccdf.c.obj
        Referenced in oscap-cvrf.c.obj
        Referenced in oscap-cvss.c.obj
        Referenced in oscap-ds.c.obj
        Referenced in oscap-info.c.obj
        Loaded getopt.lib(getopt.dll)
      Found __imp_optarg_a
        Referenced in oscap-tool.c.obj
        Referenced in oscap-xccdf.c.obj
        Referenced in oscap-cvrf.c.obj
        Referenced in oscap-ds.c.obj
        Referenced in oscap-info.c.obj
        Referenced in oscap-oval.c.obj
        Loaded getopt.lib(getopt.dll)
      Found __imp_opterr
        Referenced in oscap-tool.c.obj
        Loaded getopt.lib(getopt.dll)
      Found __IMPORT_DESCRIPTOR_getopt
        Referenced in getopt.lib(getopt.dll)
        Referenced in getopt.lib(getopt.dll)
        Referenced in getopt.lib(getopt.dll)
        Referenced in getopt.lib(getopt.dll)
        Loaded getopt.lib(getopt.dll)
      Found �getopt_NULL_THUNK_DATA
        Referenced in getopt.lib(getopt.dll)
        Loaded getopt.lib(getopt.dll)

@vicroms vicroms self-assigned this Oct 18, 2019
@JackBoosY JackBoosY removed the wip label Oct 21, 2019
@JackBoosY
Copy link
Contributor Author

@vicroms ready to merge now.

@vicroms vicroms merged commit 63a030a into microsoft:master Oct 30, 2019
@JackBoosY JackBoosY deleted the dev/jack/6169 branch October 30, 2019 06:35
ggbecker added a commit to ggbecker/openscap that referenced this pull request Mar 6, 2020
@ggbecker
Apply patch from microsoft/vcpkg#8654.
573a617
@ggbecker ggbecker mentioned this pull request Mar 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@vicroms vicroms

Labels
info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JackBoosY @MVoz @PhoebeHui @vicroms