tbb: Fix compilation on OSX #8744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure CMake detected sysroot is correctly forwarded to TBB build system so system headers files will be found later on.
|
/azp run |
|
This fix works great, please merge! https://ci.appveyor.com/project/acgetchell/cdt-plusplus/builds/28445722 https://travis-ci.org/acgetchell/CDT-plusplus/builds/604211275 |
|
@acgetchell Thanks for confirming it works for you! |
|
@tarcila TBB speeds up my triangulation code by a factor of 3, so this is a really important fix to me. Thank you for that! |
cbezault
approved these changes
Oct 31, 2019
cbezault
suggested changes
Oct 31, 2019
|
@cbezault Version bump done! |
cbezault
approved these changes
Nov 1, 2019
|
Thanks for the PR! |
MBoldyrev
added a commit
to MBoldyrev/iroha
that referenced
this pull request
Jan 29, 2020
specifically to have this patch that fixes TBB on macos: microsoft/vcpkg#8744 Signed-off-by: Mikhail Boldyrev <miboldyrev@gmail.com>
MBoldyrev
added a commit
to hyperledger/iroha
that referenced
this pull request
Feb 6, 2020
specifically to have this patch that fixes TBB on macos: microsoft/vcpkg#8744 Signed-off-by: Mikhail Boldyrev <miboldyrev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure CMake detected sysroot is correctly forwarded to TBB build
system so system headers files will be found later on.
Fixes: #8626