-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Coin3D] Add new ports for simage, Coin, and SoQt #9880
Conversation
Thank you all for the feedback. Should be integrated now. |
I found some linux regressions, please check the logs here. |
The error log states, that the file Apart from the reference to the missing I've just tested this again on a local Ubuntu 18.04 installation and it compiled without issues. |
@rickertm I will take a look. |
I can't repro that regression too, so I rerun the pipeline test. |
@ras0219-msft Could you have a look? |
The issue with the missing file |
@rickertm We are trying to resolve that. |
/azp run |
Please resolve linx regression, get log here. |
Same issue as before, file
|
4b3d8af
to
21ae010
Compare
Seems to work now after rebase to master. |
21ae010
to
2ed9ddc
Compare
Done, thank you for the suggestion. |
LGTM. Thanks for your PR. |
@rickertm what's up with the downloading distfiles for |
The upstream project has since added additional tarball archives that include the submodules, I can update the PR accordingly if you prefer. The patches have also been integrated upstream in the meantime, but there is no new tagged release version yet. |
Ah, cool, that's fine then :) just curious. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
I've added additional patches for simage when linking against a static libsndfile (FLAC and Ogg/Vorbis order). I've also disabled examples and tests. All patches have been submitted upstream. On Linux and UPW, the simage port now depends on giflib, libpng etc., as VfW, GDI+, or CGImage are not available. The Coin port adds features for optional libraries that are linked at runtime, with simage and zlib as default features. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Thanks so much @rickertm :D |
Thank you for merging this @strega-nil. |
Describe the pull request
This PR adds ports for the Coin3D libraries simage, Coin, and SoQt.
The simage port should work on all triplets.
The Coin and SoQt ports do not support ARM and UWP builds due to OpenGL. The CI baseline has been updated accordingly.
The x64-osx support for SoQt requires a fix for issue #9879.
Coin requires a dependency on boost-math until issue #8753 is addressed.
Yes.