Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Coin3D] Add new ports for simage, Coin, and SoQt #9880

Merged
merged 3 commits into from
May 8, 2020

Conversation

rickertm
Copy link
Contributor

@rickertm rickertm commented Feb 2, 2020

Describe the pull request

This PR adds ports for the Coin3D libraries simage, Coin, and SoQt.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

The simage port should work on all triplets.

The Coin and SoQt ports do not support ARM and UWP builds due to OpenGL. The CI baseline has been updated accordingly.

The x64-osx support for SoQt requires a fix for issue #9879.

Coin requires a dependency on boost-math until issue #8753 is addressed.

Yes.

ports/coin/CONTROL Show resolved Hide resolved
ports/coin/portfile.cmake Outdated Show resolved Hide resolved
ports/coin/portfile.cmake Outdated Show resolved Hide resolved
ports/coin/portfile.cmake Outdated Show resolved Hide resolved
ports/simage/CONTROL Show resolved Hide resolved
ports/simage/portfile.cmake Outdated Show resolved Hide resolved
ports/soqt/CONTROL Show resolved Hide resolved
ports/soqt/portfile.cmake Outdated Show resolved Hide resolved
ports/soqt/portfile.cmake Outdated Show resolved Hide resolved
ports/soqt/portfile.cmake Outdated Show resolved Hide resolved
ports/simage/portfile.cmake Outdated Show resolved Hide resolved
@rickertm
Copy link
Contributor Author

rickertm commented Feb 3, 2020

Thank you all for the feedback. Should be integrated now.

@JackBoosY
Copy link
Contributor

I found some linux regressions, please check the logs here.

@rickertm
Copy link
Contributor Author

rickertm commented Feb 3, 2020

The error log states, that the file /ci/myagent/_work/1/s/installed/x64-linux/share/cmake/Qt5Gui/Qt5GuiConfigExtras.cmake of package qt5-base contains a reference to file /ci/myagent/_work/3/s/installed/x64-linux/lib/libEGL.so that apparently does not exist on disk.

Apart from the reference to the missing libEGL.so file in /ci/myagent/_work/3/..., all other entries in the log file point to the directory /ci/myagent/_work/1/...?

I've just tested this again on a local Ubuntu 18.04 installation and it compiled without issues.

@JackBoosY
Copy link
Contributor

@rickertm I will take a look.

@JackBoosY
Copy link
Contributor

I can't repro that regression too, so I rerun the pipeline test.

@JackBoosY
Copy link
Contributor

@ras0219-msft Could you have a look?

@rickertm
Copy link
Contributor Author

The issue with the missing file /ci/myagent/_work/3/s/installed/x64-linux/lib/libEGL.so seems to have been addressed in #10390?

@JackBoosY
Copy link
Contributor

@rickertm We are trying to resolve that.

@JackBoosY
Copy link
Contributor

/azp run

@JackBoosY
Copy link
Contributor

Please resolve linx regression, get log here.

@rickertm
Copy link
Contributor Author

Same issue as before, file libEGL.so is still missing and references folder /ci/myagent/_work/2/... instead of /ci/myagent/_work/3/...

CMake Error at /ci/myagent/_work/3/s/installed/x64-linux/share/cmake/Qt5Gui/Qt5GuiConfig.cmake:15 (message):
  The imported target "Qt5::Gui" references the file

     "/ci/myagent/_work/2/s/installed/x64-linux/lib/libEGL.so"

  but this file does not exist.  Possible reasons include:

@rickertm
Copy link
Contributor Author

Seems to work now after rebase to master.

@rickertm rickertm marked this pull request as ready for review March 26, 2020 15:32
ports/coin/CONTROL Show resolved Hide resolved
ports/soqt/CONTROL Show resolved Hide resolved
@rickertm
Copy link
Contributor Author

Done, thank you for the suggestion.

@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed waiting for response labels Mar 27, 2020
@NancyLi1013
Copy link
Contributor

LGTM. Thanks for your PR.

@strega-nil
Copy link
Contributor

@rickertm what's up with the downloading distfiles for soanydata and sogui, as opposed to setting up ports for them by themselves? I don't think I understand.

@rickertm
Copy link
Contributor Author

rickertm commented May 1, 2020

soanydata and sogui are submodules that were not included in the tarball archive at the time of this PR, so I followed the canonical way for this case described in #1036.

The upstream project has since added additional tarball archives that include the submodules, I can update the PR accordingly if you prefer. The patches have also been integrated upstream in the meantime, but there is no new tagged release version yet.

@strega-nil
Copy link
Contributor

Ah, cool, that's fine then :) just curious.

@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rickertm
Copy link
Contributor Author

rickertm commented May 2, 2020

I've added additional patches for simage when linking against a static libsndfile (FLAC and Ogg/Vorbis order). I've also disabled examples and tests. All patches have been submitted upstream.

On Linux and UPW, the simage port now depends on giflib, libpng etc., as VfW, GDI+, or CGImage are not available.

The Coin port adds features for optional libraries that are linked at runtime, with simage and zlib as default features.

@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY
Copy link
Contributor

libqcow:x64-linux regression are not related with this PR.

@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strega-nil strega-nil merged commit 2fc37d5 into microsoft:master May 8, 2020
@strega-nil
Copy link
Contributor

Thanks so much @rickertm :D

@rickertm
Copy link
Contributor Author

rickertm commented May 8, 2020

Thank you for merging this @strega-nil.

@rickertm rickertm deleted the add-port-coin3d branch May 8, 2020 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants