RT Tests compilation failure

[sergey-melnychuk]

Without extra -DRT_TESTS=ON passed to cmake, I managed to follow the README to configure, build/install verona and successfully run provided examples.

Yet with -DRT_TESTS=ON I get compilation error (details below). Am I doing something wrong?

HEAD: 7bdf0f84f58f844411b093e34f57acd54ebd8a40

$ uname -a
Darwin MacBook-Air.local 19.2.0 Darwin Kernel Version 19.2.0: Sat Nov  9 03:47:04 PST 2019; root:xnu-6153.61.1~20/RELEASE_X86_64 x86_64
$ cmake --version
cmake version 3.16.2
$ ninja --version
1.9.0

$ mkdir build_ninja && cd build_ninja
$ cmake .. -GNinja -DCMAKE_BUILD_TYPE=Debug -DRT_TESTS=ON
-- The CXX compiler identification is AppleClang 11.0.0.11000033
-- Check for working CXX compiler: /Library/Developer/CommandLineTools/usr/bin/c++
-- Check for working CXX compiler: /Library/Developer/CommandLineTools/usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Version: 5.3.1
-- Build type: Debug
-- CXX_STANDARD: 17
-- Performing Test has_std_17_flag
-- Performing Test has_std_17_flag - Success
-- Performing Test has_std_1z_flag
-- Performing Test has_std_1z_flag - Success
-- Performing Test SUPPORTS_VARIADIC_TEMPLATES
-- Performing Test SUPPORTS_VARIADIC_TEMPLATES - Success
-- Performing Test SUPPORTS_USER_DEFINED_LITERALS
-- Performing Test SUPPORTS_USER_DEFINED_LITERALS - Success
-- Performing Test FMT_HAS_VARIANT
-- Performing Test FMT_HAS_VARIANT - Success
-- Performing Test HAS_NULLPTR_WARNING
-- Performing Test HAS_NULLPTR_WARNING - Success
-- Looking for open
-- Looking for open - found
-- The C compiler identification is AppleClang 11.0.0.11000033
-- Check for working C compiler: /Library/Developer/CommandLineTools/usr/bin/cc
-- Check for working C compiler: /Library/Developer/CommandLineTools/usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Performing Test CXX_FILESYSTEM
-- Performing Test CXX_FILESYSTEM - Success
-- Looking for _LIBCPP_VERSION
-- Looking for _LIBCPP_VERSION - found
CMake Warning at src/rt/external/snmalloc/CMakeLists.txt:54 (message):
  Not generating clangformat target, no clang-format tool found
Call Stack (most recent call first):
  src/CMakeLists.txt:28 (clangformat_targets)


-- Found Python3: /usr/local/Frameworks/Python.framework/Versions/3.7/bin/python3.7 (found version "3.7.4") found components: Interpreter
-- Configuring done
-- Generating done
-- Build files have been written to: <snip>/verona/build_ninja
$ ninja install
[36/153] Building CXX object src/rt/CMakeFiles/func-con-cowngc4.dir/test/func/cowngc4/cowngc4.cc.o
FAILED: src/rt/CMakeFiles/func-con-cowngc4.dir/test/func/cowngc4/cowngc4.cc.o
/Library/Developer/CommandLineTools/usr/bin/c++  -DSNMALLOC_CHEAP_CHECKS -DUSE_EXECINFO -DUSE_FLIGHT_RECORDER -DUSE_QUICK_EXIT -I../src/. -I../src/rt/. -I../src/rt/external/snmalloc/src -g -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk   -Wsign-conversion -Wall -Wextra -Werror -Wundef -mcx16 -march=native -std=gnu++1z -MD -MT src/rt/CMakeFiles/func-con-cowngc4.dir/test/func/cowngc4/cowngc4.cc.o -MF src/rt/CMakeFiles/func-con-cowngc4.dir/test/func/cowngc4/cowngc4.cc.o.d -o src/rt/CMakeFiles/func-con-cowngc4.dir/test/func/cowngc4/cowngc4.cc.o -c ../src/rt/test/func/cowngc4/cowngc4.cc
../src/rt/test/func/cowngc4/cowngc4.cc:384:11: error: no matching member function for call to 'run'
  harness.run(test_cown_gc<RegionType::Trace>, forward, ring, &rand);
  ~~~~~~~~^~~
../src/rt/./test/harness.h:73:8: note: candidate template ignored: deduced conflicting types for parameter 'Args' (<unsigned long long, unsigned long, PRNG *> vs. <unsigned long, unsigned long, PRNG *>)
  void run(void f(Args...), Args... args)
       ^
../src/rt/test/func/cowngc4/cowngc4.cc:385:11: error: no matching member function for call to 'run'
  harness.run(test_cown_gc<RegionType::Arena>, forward, ring, &rand);
  ~~~~~~~~^~~
../src/rt/./test/harness.h:73:8: note: candidate template ignored: deduced conflicting types for parameter 'Args' (<unsigned long long, unsigned long, PRNG *> vs. <unsigned long, unsigned long, PRNG *>)
  void run(void f(Args...), Args... args)
       ^
2 errors generated.
[41/153] Building CXX object src/rt/CMakeFiles/func-sys-cowngc3.dir/test/func/cowngc3/cowngc3.cc.o
ninja: build stopped: subcommand failed.

[mjp41]

Sorry, when we added CI for MacOS, we didn't add a separate build for the runtime tests.

@plietar, would you be able to try and fix the build on MacOS for the stand alone runtime tests.

[plietar]

Yep, I got the same issue here. Will work on it.