Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ImportMany] collection property has no setter, and is improperly rejected #94

Closed
AArnott opened this issue May 10, 2018 · 0 comments
Closed

[ImportMany] collection property has no setter, and is improperly rejected #94

AArnott opened this issue May 10, 2018 · 0 comments
Assignees
@AArnott
Labels
bug
Milestone
15.8

Comments

@AArnott
Copy link
Member

AArnott commented May 10, 2018

The fix for #61 ended up regressing the scenario when an ImportMany collection has no setter but needn't have one because it is set by the importing constructor.
@AArnott AArnott added the bug label May 10, 2018
@AArnott AArnott added this to the 15.8 milestone May 10, 2018
@AArnott AArnott self-assigned this May 10, 2018
AArnott added a commit that referenced this issue May 10, 2018
@AArnott
Re-enable MEF parts to omit the property setter on [ImportMany] prope…
d3ac37d 
…rties

The case where this would actually work at runtime is when the MEF part's ImportingConstructor sets the value of the ImportMany property to an (empty) collection, in which case MEF will simply add elements to it and never have to access the setter.

Fixes #94
@AArnott AArnott mentioned this issue May 10, 2018
Merged
AArnott added a commit that referenced this issue May 10, 2018
@AArnott
Re-enable MEF parts to omit the property setter on [ImportMany] prope…
62dbdc8 
…rties

The case where this would actually work at runtime is when the MEF part's ImportingConstructor sets the value of the ImportMany property to an (empty) collection, in which case MEF will simply add elements to it and never have to access the setter.

Fixes #94
@ZoeyR ZoeyR closed this as completed in #95 May 10, 2018
@lifengl lifengl mentioned this issue Mar 7, 2019
Open
AArnott pushed a commit that referenced this issue Jun 7, 2022
@dependabot
Bump coverlet.msbuild from 3.0.2 to 3.0.3 (#94)
bf34bea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AArnott AArnott

Labels
bug
Projects
None yet
Milestone
15.8
Development

No branches or pull requests
1 participant
@AArnott