Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ordinal comparisons #327

Merged
merged 1 commit into from Jun 23, 2022
Merged

Conversation

davkean
Copy link
Member

@davkean davkean commented Jun 22, 2022

Reduce the time it takes to find v1 and v2 export factory instances, this was costing 200ms in Startup.BuildingMEFCache perf test. These were previously using cultural-aware comparisons.

CPU time:
image

Reduce the time it takes to find v1 and v2 export factory instances, this was costing 200ms in Startup.BuildingMEFCache perf test.
@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2022

Codecov Report

Merging #327 (3a5bd8c) into main (0fcb0c1) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #327   +/-   ##
=======================================
  Coverage   76.10%   76.10%           
=======================================
  Files         110      110           
  Lines        7174     7174           
=======================================
  Hits         5460     5460           
  Misses       1714     1714           
Impacted Files Coverage Δ
...figuration/ExportMetadataViewInterfaceEmitProxy.cs 92.85% <100.00%> (ø)
...icrosoft.VisualStudio.Composition/ExportFactory.cs 100.00% <100.00%> (ø)
...crosoft.VisualStudio.Composition/ExportProvider.cs 96.39% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fcb0c1...3a5bd8c. Read the comment docs.

@AArnott AArnott merged commit 8c08afe into microsoft:main Jun 23, 2022
@AArnott AArnott added this to the v17.3 milestone Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants