Update ThirdPartyNotice.txt file #87
Conversation
There was a problem hiding this comment.
Why is it we have to check this in, when CG can generate notice files for us automatically?
In fact our pipeline is already doing this. I'm sorry if I just forgot if you already answered this.
|
I didn't know our pipeline was doing it automatically, I was just following the directions on the compliance work item. I did generate this file automatically using CG though. I'll get this checked in anyways just to cover my bases. |
|
Generation of the NOTICE file doesn't equate to shipping it in the NPM package. IMO the ideal fix for this would be to remove the manually constructed NOTICE file, and adjust the pipeline to drop the NOTICE file (or a copy of it at least) that is generated by the pipeline into the NPM directory before it is packed. Then you never have to manually update again. |
No description provided.