Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AddLocalRpcTarget<IServerDerived> does not publish events in parent interface #781

Closed
rruizGit opened this issue Mar 22, 2022 · 0 comments · Fixed by #782
Closed

AddLocalRpcTarget<IServerDerived> does not publish events in parent interface #781

rruizGit opened this issue Mar 22, 2022 · 0 comments · Fixed by #782
Labels
bug
Milestone
v2.11

Comments

@rruizGit
Copy link
Contributor

In the case where:

public interface IServerDerived : IServer

where IServer declares an event and

JsonRpc.AddLocalRpcTarget

is employed to publish the object using an interface, the methods of the parent interface (IServer) will be available but not the events.

(I will be adding a PR shortly with an extra unit test that exercises this situation along with a fix).
rruizGit pushed a commit to rruizGit/vs-streamjsonrpc that referenced this issue Mar 22, 2022
Unit test and fix for Issue microsoft#781.
423622e
rruizGit pushed a commit to rruizGit/vs-streamjsonrpc that referenced this issue Mar 22, 2022
Fix for issue microsoft#781.
303319e
@rruizGit rruizGit mentioned this issue Mar 22, 2022
Merged
@AArnott AArnott linked a pull request Mar 25, 2022 that will close this issue
Hook events in base interfaces when calling AddLocalRpcTarget<T> #782
Merged
@AArnott AArnott added the bug label Mar 25, 2022
@AArnott AArnott changed the title AddLocalRpcTarget<IServerDerived> does not publish events in parent interface. AddLocalRpcTarget<IServerDerived> does not publish events in parent interface Mar 25, 2022
@AArnott AArnott changed the title AddLocalRpcTarget<IServerDerived> does not publish events in parent interface AddLocalRpcTarget<IServerDerived> does not publish events in parent interface Mar 25, 2022
@AArnott AArnott added this to the v2.11 milestone Mar 25, 2022
@AArnott AArnott closed this as completed Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v2.11
Development

Successfully merging a pull request may close this issue.

Hook events in base interfaces when calling AddLocalRpcTarget<T> rruizGit/vs-streamjsonrpc
2 participants
@AArnott @rruizGit