-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Headers support for WebSocketMessageHandler #98
Comments
That seems reasonable. |
I think the solution is to let vs-jsonrpc to remove the headers as the header is not necessary at all. While for StreamJsonRPC, in order to work with other library, I think the header should be configurable. |
You can do this today by exposing your WebSocket as a stream and then using the If #80 is fixed, that may allow us to offer |
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.9.1 to 16.9.4. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](microsoft/vstest@v16.9.1...v16.9.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
I am using vscode-ws-jsonrpc from client side and using vs-streamjsonrpc from server side. The communication is through WebSocket.
While vscode-ws-jsonrpc always expect headers in the message (sending and receiving)
Could you please abstract the Headers feature from HeaderDelimitedMessageHandler and make it to be configurable for these message handlers so that we can enable /disable as needed for different jsonrpc libs?
The text was updated successfully, but these errors were encountered: