Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace test project's netcoreapp2.2 target with netcoreapp3.1 #401

Merged
merged 1 commit into from Jan 2, 2020

Conversation

AArnott
Copy link
Member

@AArnott AArnott commented Jan 2, 2020

netcoreapp2.2 is no longer supported or serviced.
netcoreapp2.1 and 3.1 are LTS releases, so testing on them seems valuable.

netcoreapp2.2 is no longer supported or serviced.
netcoreapp2.1 and 3.1 are LTS releases, so testing on them seems valuable.
@AArnott AArnott added this to the v2.3 milestone Jan 2, 2020
@AArnott AArnott self-assigned this Jan 2, 2020
@codecov-io
Copy link

Codecov Report

Merging #401 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #401      +/-   ##
==========================================
- Coverage   90.14%   90.09%   -0.06%     
==========================================
  Files          47       47              
  Lines        3624     3624              
==========================================
- Hits         3267     3265       -2     
- Misses        357      359       +2
Impacted Files Coverage Δ
src/StreamJsonRpc/HeaderDelimitedMessageHandler.cs 85.38% <0%> (-0.59%) ⬇️
src/StreamJsonRpc/JsonRpc.cs 92.81% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c720280...b37d3cd. Read the comment docs.

@AArnott AArnott merged commit f1565ae into microsoft:master Jan 2, 2020
@AArnott AArnott deleted the netcoreapp3.1 branch January 2, 2020 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants