Revert "Prevent creating two task waiting chains when joins AsyncLazy." #1011
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #999
I have concern on this PR to have potential impact to the performance of the product. The reason:
when this code is executed on UI thread context:
await asyncLazy.GetValueAsync().ConfigureAwait(false)
and the inner task of the async lazy completes on a thread pool. Before this code, this continuation doesn't need back to the UI thread, but joinableTask.JoinAsync would need back to the UI thread to complete. I think it is unnecessary in JoinAsync code, but it will require further changes to get this more complicated.