New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache boxed bool values to reduce allocation overhead #1012

Merged

davkean merged 1 commit into microsoft:main from Erarndt:avoidBoolBoxing

Apr 1, 2022

Contributor

Erarndt commented Mar 30, 2022

There are around 1MB of allocations caused by boxing boolean values when opening up Orchard Core which we can avoid by caching the values.


          Cache boxed bool values to reduce allocation overhead

600cb05

Therzok approved these changes

View reviewed changes

davkean approved these changes

View reviewed changes

Member

davkean commented Apr 1, 2022

Note this only shows up under ETL tracing, but helps to reduce the noise as we're looking through these.

davkean merged commit 2b3b6d1 into microsoft:main

AArnott added this to the v17.3 milestone

AArnott added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment