Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference search shows matches in the same file under different paths #25

Closed
egamma opened this issue Mar 9, 2022 · 3 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone

Comments

@egamma
Copy link
Member

egamma commented Mar 9, 2022

-> the same match is reported twice in different files, but there is only a single pycore_ash.t in this repository
image

@jrieken
Copy link
Member

jrieken commented Mar 9, 2022

Looks like there is two variants of this file: one is the actual file (vscode-vfs-scheme) and another one seems to be from the review-scheme. I assume the later is from GHPR extension and should be filtered

Screenshot 2022-03-09 at 17 01 37

@jrieken jrieken added the bug Issue identified by VS Code Team member as probable bug label Mar 9, 2022
@jrieken jrieken added this to the March 2022 milestone Mar 9, 2022
jrieken added a commit that referenced this issue Mar 9, 2022
@jrieken
Copy link
Member

jrieken commented Mar 9, 2022

There is a list that contains schemes that we ignore. This has debt written all over it but will do for now.

@jrieken
Copy link
Member

jrieken commented Mar 9, 2022

Instead of having the static filter-list we should probably have an allow list which is all schemas file-search found - plus some special scheme, like notebooks

jrieken added a commit that referenced this issue Mar 9, 2022
@jrieken jrieken closed this as completed Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

2 participants