Fixes from other extensions #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eleanorjboyd
approved these changes
Jun 2, 2023
karthiknadig
force-pushed
the
filter-args1
branch
from
942918e
to
9625f93
Compare
eleanorjboyd
approved these changes
Jun 5, 2023
| return pathlib.Path(file_path1) == pathlib.Path(file_path2) | ||
|
|
||
|
|
||
| def normalize_path(file_path: str) -> str: |
There was a problem hiding this comment.
how did this function before without the path normalization?
There was a problem hiding this comment.
Normally we don't need path normalization. It is needed in windows if user launches VS Code using case different from the one used in the workspace name. This bug is not hit commonly. But we need to propagate this fix to all extensions in python extension set.
| def is_stdlib_file(file_path) -> bool: | ||
| """Return True if the file belongs to standard library.""" | ||
| return os.path.normcase(os.path.normpath(file_path)).startswith(_site_paths) | ||
| def is_stdlib_file(file_path: str) -> bool: |
There was a problem hiding this comment.
is this the standard library for autopep8 specifically?
There was a problem hiding this comment.
Nope, this is general standard library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.