New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added workaround and early returning if file name matches excluded arg #142
Added workaround and early returning if file name matches excluded arg #142
Conversation
@microsoft-github-policy-service agree |
@kirankumarmanku This particular scenario requires its own test. Add test here https://github.com/microsoft/vscode-autopep8/blob/main/src/test/python_tests/test_formatting.py You can update arguments passed to the server like this:
|
@karthiknadig , |
The |
If you have not set up the repo for development follow the steps here: https://github.com/microsoft/vscode-autopep8/wiki/Contributing-Guide Once you have it set up you should see tests in the test explorer: You can set breakpoint in python code and click on this button for your test case: |
@karthiknadig , |
@karthiknadig, |
You might need to add |
I updated the PR @karthiknadig. Please take a look! |
@karthiknadig , it seems I need one more approval from the Community. How do I get that? |
@karthiknadig , @lramos15 Thank you for approving the PR. Can you also merge this? I don't have write access for the repository to do that. |
In this PR, I am checking if the file name matches in excluded args in settings file and doing an early return.
The check is similar to how autopep8 does its matching here: https://github.com/hhatto/autopep8/blob/5b9110ba53fecd60cd3091fb66d808e8ced3b2e8/autopep8.py#L4359