Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change return to await when provision cloud shell #48

Closed
wants to merge 1 commit into from

Conversation

jdneo
Copy link
Member

@jdneo jdneo commented Mar 26, 2018

resolve: #45

@chrmarti
Copy link
Contributor

Thanks for your contribution!

I looked into this a little more and found that the user has a better indication of progress when letting the terminal open first. Will push a change.

@chrmarti chrmarti closed this Mar 29, 2018
@jdneo jdneo deleted the cs/await-login branch March 29, 2018 09:01
@jdneo
Copy link
Member Author

jdneo commented Mar 29, 2018

Thanks @chrmarti . Looking forward to the new experience 😄

@jdneo
Copy link
Member Author

jdneo commented Apr 4, 2018

@chrmarti I saw your code change and tested on my side. I like the experience that telling user sign in needed in the terminal panel. Thanks!

But when user hasn't signed in at begining, I got Entry not found in cache. error when calling acquireToken(). Is that becaus I missed something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could we continue the command 'azure-account.askForLogin' when creating cloud shell
3 participants