Allow users to specify whether to install Node.js template #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adashen
reviewed
Dec 20, 2018
| @@ -328,10 +331,10 @@ export class EdgeManager { | |||
|
|
|||
| const needUpdateRegistry: boolean = template !== Constants.STREAM_ANALYTICS; | |||
|
|
|||
| const {usernameEnv, passwordEnv} = await this.addModuleToDeploymentTemplate(templateJson, templateFile, envFilePath, moduleInfo, needUpdateRegistry, isNewSolution); | |||
| const { usernameEnv, passwordEnv } = await this.addModuleToDeploymentTemplate(templateJson, templateFile, envFilePath, moduleInfo, needUpdateRegistry, isNewSolution); | |||
There was a problem hiding this comment.
for all the white space in brackets，we should define a rule in tslint.
adashen
reviewed
Dec 20, 2018
| @@ -778,7 +796,7 @@ export class EdgeManager { | |||
| if (!templatePick) { | |||
| throw new UserCancelledError(); | |||
| } | |||
| TelemetryClient.sendEvent( `${Constants.addModuleEvent}.selectModuleTemplate`, { | |||
| TelemetryClient.sendEvent(`${Constants.addModuleEvent}.selectModuleTemplate`, { | |||
There was a problem hiding this comment.
for this space, we could add config "space-within-parens": true into tslint.json
adashen
reviewed
Dec 20, 2018
| ExposedPorts: {"5678/tcp": {}}, | ||
| HostConfig: {PortBindings: {"5678/tcp": [{HostPort: "5678"}]}}}; | ||
| ExposedPorts: { "5678/tcp": {} }, | ||
| HostConfig: { PortBindings: { "5678/tcp": [{ HostPort: "5678" }] } }, |
There was a problem hiding this comment.
actually I will prefer no space between curly braces.
There was a problem hiding this comment.
This is the result of a "Format code" command...
adashen
approved these changes
Dec 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.