Final "Build Image in Azure" #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Migrate docker buildImageInAzure code * Add storage-blob dependency * Spelling change * Incorporate comments * Add BuildImageStep * Incorporate requested changes * Change activity message * Change DockerFileitemStep.ts name
* Add capabilities for remoteAcrBuild * cleanup * Small changes * Add name change to ImageSourceListStep also * PR feedback
nturinski
approved these changes
Mar 22, 2023
| @@ -14,6 +14,7 @@ export interface IDeployBaseContext extends ISubscriptionActionContext { | |||
| targetContainer?: ContainerAppModel; | |||
|
|
|||
| imageSource?: ImageSourceValues; | |||
| buildType?: string; | |||
There was a problem hiding this comment.
Also, we should try to document these context properties where necessary. How are these properties used and what do they control?
nturinski
approved these changes
Mar 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #286.