Use admin api to get function keys #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/tree/FunctionTreeItem.ts
Outdated
| const triggerUrl: URL = new URL(`${this.client.defaultHostUrl}/api/${this._name}`); | ||
| const key: string | undefined = await this.getKey(); | ||
| if (key) { | ||
| // tslint:disable-next-line:no-backbone-get-set-outside-model |
There was a problem hiding this comment.
Given that you're not using backbone/, you should probably just disable this rule
| const data: string = await functionsAdminRequest(this.client, urlPath); | ||
| try { | ||
| // tslint:disable-next-line:no-unsafe-any | ||
| const result: string = JSON.parse(data).value; |
There was a problem hiding this comment.
I had more like with:
const result = JSON.parse(data).value
may depend on your tslint settings though
StephenWeatherford
approved these changes
Sep 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #567
Based on the discussion here: Azure/azure-functions-host#3411, the kudu api is deprecated and the ARM api is not ready. However, the admin api works
Relies on this PR in shared package: microsoft/vscode-azuretools#264