Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed "Open in File Explorer" command to "Open in Explorer" #1110

Merged
merged 2 commits into from
Aug 11, 2022
Merged

Renamed "Open in File Explorer" command to "Open in Explorer" #1110

merged 2 commits into from
Aug 11, 2022

Conversation

motm32
Copy link
Contributor

@motm32 motm32 commented Aug 11, 2022

Fixes #954

@motm32 motm32 requested a review from a team as a code owner August 11, 2022 18:21
bwateratmsft
bwateratmsft previously approved these changes Aug 11, 2022
View reviewed changes
nturinski
nturinski requested changes Aug 11, 2022
View reviewed changes
Copy link
Member

@nturinski nturinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, there are a couple more strings that say "Open in File Explorer..." that need to be converted!

@nturinski
Copy link
Member

How many engineer's approvals does it take to get a string changed?
KneeSlapGIF

@motm32 motm32 merged commit 0e7bca4 into main Aug 11, 2022
@motm32 motm32 deleted the meganmott/fix954 branch August 11, 2022 20:43
@alexweininger
Copy link
Member

@microsoft microsoft locked and limited conversation to collaborators Sep 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nturinski nturinski nturinski approved these changes

@alexweininger alexweininger alexweininger approved these changes

@bwateratmsft bwateratmsft bwateratmsft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename "Open in File Explorer" command to "Open in Explorer"
4 participants
@motm32 @nturinski @alexweininger @bwateratmsft