-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BlobContainerFS core logic #1227
BlobContainerFS core logic #1227
Conversation
0b0630a
to
a551332
Compare
Got the build to pass! 🎉 |
We'll need to also support attached storage accounts somehow. I just tested the current fs provider and it works perfectly with attached storage accounts. So we have two options:
I'm sorta voting for option 2 since the attached accounts feature may need a larger rework to get it to work well with the new fs provider. |
I reverted breaking changes to the AzureStorageFS and added code to use it for attached storage accounts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my testing it works really well. Lets merge this to get CTI testing done on it and then we can see about releasing this to unblock users from this scenario.
We can leave the fancier stuff like integrating this with the tree view for later.
Is there anything needed before merging the PR? |
Go ahead and merge. |
Implements FileSystemProvider for Azure blobs. The new FS provider no longer queries the tree view for the container node and provides a faster readFile/readDirectory experience. It also implements rename for hierarchical namespace containers.